[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] [x86_64] Fixing PGT_va_mutable and PGT_va_unknown




On 15 Aug 2005, at 08:50, Nakajima, Jun wrote:

Okay, but I see no reason to change PGT_va_mask. You already include
28 bits where you actually need only 27 bits of backptr.

The current one
#define PGT_va_mask         ((unsigned long)((1U<<28)-1)<<PGT_va_shift)
includes only 27 bits (see -1).

(1<<n)-1 sets the n least significant bits, not n-1.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.