[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Fix vnc-dryrun option interaction



Arun Sharma wrote:
Keir Fraser wrote:


On 23 Jun 2005, at 17:57, Arun Sharma wrote:

Please apply this patch. It fixes two problems:



The patch is missing. :-)


I meant the patch George posted :)

There's a problem with that patch.

I think this patch is better. With George's patch (and my original patch) xm create -n shows (vnc 0), even when vnc=1 in the config file.

        -Arun
diff -r 3b939e817833 tools/python/xen/xm/create.py
--- a/tools/python/xen/xm/create.py     Thu Jun 23 16:38:32 2005
+++ b/tools/python/xen/xm/create.py     Thu Jun 23 13:30:06 2005
@@ -545,7 +545,7 @@
     """If vnc was specified, spawn a vncviewer in listen mode
     and pass its address to the domain on the kernel command line.
     """
-    if not vals.vnc: return
+    if not vals.vnc or vals.dryrun: return
     vnc_display = choose_vnc_display()
     if not vnc_display:
         opts.warn("No free vnc display")
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.