[Xen-devel] [PATCH] xc_domain_getinfo should zero info struct; can leave crashed flag set otherwise

[Josh Triplett <josht@xxxxxxxxxx>]

The xc_domain_getinfo does not clear the info structure before filling 
it in, and in some circumstances it doesn't completely fill in the 
structure for each domain.  In particular, it sets the crashed flag if 
the domain has crashed, but does not clear it if the domain has not 
crashed, so the crashed flag may be random stack garbage from the 
calling program.  With the attached patch (against the latest nightly), 
xc_domain_getinfo zeroes the array of info structures before filling 
them in.
Signed-off-by: Josh Triplett <josht@xxxxxxxxxx>

- Josh Triplett

diff -Nur xen-unstable.orig/tools/libxc/xc_domain.c 
xen-unstable/tools/libxc/xc_domain.c
--- xen-unstable.orig/tools/libxc/xc_domain.c   2005-06-12 20:13:42.000000000 
-0700
+++ xen-unstable/tools/libxc/xc_domain.c        2005-06-15 18:31:24.000000000 
-0700
@@ -77,6 +77,8 @@
     dom0_op_t op;
     int rc = 0; 
 
+    memset(info, 0, max_doms*sizeof(xc_dominfo_t));
+
     for ( nr_doms = 0; nr_doms < max_doms; nr_doms++ )
     {
         op.cmd = DOM0_GETDOMAININFO;

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel