[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xs.h and xs_lib.h


  • To: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
  • From: aq <aquynh@xxxxxxxxx>
  • Date: Tue, 14 Jun 2005 13:46:54 +0900
  • Cc: Xen Dev <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 14 Jun 2005 04:46:04 +0000
  • Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=qYsYq0oaDLA0FAFWzJb1Z2Go+z/1HpdtvqVUlYc6JAM/WNSPwdJJqmi+nnPj7VxkkIDoo8W+UpH0VJI56n5arPNo5h9Q9c3X1f4S30ssme6ICvDWYCDjT4O9YFS3yCfra4bk5L+BBpU+0cdmoZjSXjBSG2k9Uacb20pdjTUAQZk=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

On 6/14/05, Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:
> On Mon, 2005-06-13 at 00:14 +0900, aq wrote:
> > On 6/12/05, Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:
> > > On Fri, 2005-06-10 at 03:32 -0500, aq wrote:
> > > > This patch moves declaration of xs_handle from xs.c to xs.h.
> > >
> > > No; why do this?  It's opaque for a reason.  Originally it was just an
> > > int, but Keir insisted it be an opaque structure.  Exposing it binds us
> > > to the current structure again.
> > >
> > > > Besides,
> > > > it installs xs.h and xs_lib.h to /usr/include, and gets top Makefile
> > > > uninstalled them when cleaning up.
> > >
> > > xs_lib.h should not be installed in /usr/include!
> >
> > i see that, but where should we put this header?
> 
> Once the daemon and library are built, it's not necessary for anything.
> 

i installed xs_lib.h because xs.h includes it. now we need to remove
this and include xs_lib.h in other files as needed.

later i will send in another patch to fix this, and revert the problem
raised in last patch.

regards,
aq

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.