[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-devel] DOM0_GETDOMAININFO intended behavior



On Wed, 2005-06-08 at 11:42 +0100, Ian Pratt wrote:
> > > Passing a flag in to explicitly request that you want to 
> > iterate would 
> > > probably be an improvement to the interface. 
> > 
> > Instead of changing the interface and the applications, how about the
> > following: If you request a specific domain id and it doesn't 
> > exist, you get back the expected result. If, however, you 
> > want a list of domains it works like it has been.
> 
> Hmm, I'm not sure I like this. It turns a relatively minor 'gotcha' of
> the hypervisor interface into something that's more confusing: if you're
> trying to iterate over domains using xc_domain_getinfo then you have to
> ask for at least two domains at a time otherwise you'll get ESRCH.
> 
> I think the cleanest fix is just to add an 'iterate' flag to the
> parameters in GETDOMAININFO, no?


Ok... now that I (unintentionally) went overboard on this, why not just
document how it works and leave it as is? What will the flag really buy
you? 

Sorry for the hoo ha. <grin>

What about just adding the following:

signed-off-by: dsteklof@xxxxxxxxxx


Attachment: xc_domain_getinfo-add-comment.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.