[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-devel] [PATCH] reiserfs module for pygrub

  • To: "Jeremy Katz" <katzj@xxxxxxxxxx>
  • From: "Ian Pratt" <m+Ian.Pratt@xxxxxxxxxxxx>
  • Date: Tue, 24 May 2005 01:14:22 +0100
  • Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 24 May 2005 00:13:47 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcVf807QqDo4+BthSnWOKPaj5u8bxQAAY5tw
  • Thread-topic: [Xen-devel] [PATCH] reiserfs module for pygrub

> What if we check instead for the headers being present and 
> only building the filesystem modules that there's support for 
> on the system?  Then distributors can ensure they have the 
> right things in their buildsystem and anyone else can do the 
> same.  The attached patch should implement that for libext2fs.

Seems a sensible approach to me. Some people will no doubt hate the fact
that the output will depend on the build host. Perhaps have an
environment variable that can be set to overide the autodetect? (and
hence cause a build failure)
> > Also, at runtime, are there
> > issues with libraries being present? Can you load the library 
> > dynamically if required?
> The libraries get linked dynamically into the python module.  
> If at runtime, the library isn't present, it won't cause a 
> fatal error (you won't be able to access those types of 
> filesystems, but it won't fall over on the import)

Given that the libext2fs is 90KB, I wander if we should just staticaly
link? Not sure.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.