[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] make domu_debug run-time option + fix int3 handling for MP

  • To: Kip Macy <kmacy@xxxxxxxxxx>
  • From: Christian Limpach <christian.limpach@xxxxxxxxx>
  • Date: Mon, 16 May 2005 22:55:49 +0100
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
  • Delivery-date: Mon, 16 May 2005 21:55:19 +0000
  • Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=JbohquVRD7oSB6fO5bvC8nUwwg8dcxWReyttaB60MV47Nj1QkkDUAupNZuIOSyLkZ8/VQuhAf0xsbeQqee4Aa5jc3Lp2GS6EBwCj2SYu4VoJo7UYqAmCZ1m6xB6BFJ4fUecDFNqv+7VHXi/HXdw25pWOljMT6w6xHy1T3AV55Sw=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

On 5/16/05, Kip Macy <kmacy@xxxxxxxxxx> wrote:
> I'm not entirely thrilled with the interfaces used to get the domu_debug 
> option
> into xen, but adding yet another argument xc_linux_build and/or adding a
> separate handler for domu_debug didn't seem that clean either. The debug 
> support
> doesn't seem like something Ron would use, so I didn't update the Plan 9
> builder.

Looks allright -- except that the debugger.h changes break the
non-domu_debug usages.  Even if you fix that, I'm not sure we want
debugger_trap_entry to be domu_debug only.  Could you please explain
what the intent is and resend as separate patches?
Maybe a debug_trap_entry wrapper which tests the DOMF_debug flag and
either calls the domu_debug function or the other debugger function
would be better?  Please also leave the #if/#elif construct for easy
switching between the different debugger stubs...


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.