[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] recent major -unstable changes cause ia64 build to bebroken

On May 11, 2005, at 10:33 AM, Ian Pratt wrote:

Another new problem due to a common change...

xen/include/xen/cpumask.h declares:

  extern cpumask_t cpu_online_map;

However, with CONFIG_SMP off, xen/include/xen/smp.h defines
cpu_online_map to 1.

It's daft that we even have a CONFIG_SMP option in Xen. It spends most
of its time broken because no-one using x86 builds it, and you won't
even be able to buy any non SMP hardware before long...

I'd vote for expunging CONFIG_SMP.

I've had this problem before too, and I wished that UP Xen would build, since so far I haven't worried about SMP on PowerPC at all, and I think Dan is in the same situation.

However, since nobody builds UP on x86 then it will continually be broken. I guess we could say goodbye to CONFIG_SMP and architectures without SMP support can just stub out the SMP functions, #define NR_CPUS 1, etc. This is what I'm doing now... Dan, does that work for you?

Hollis Blanchard
IBM Linux Technology Center

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.