[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] semantics of GETDOMAININFO

  • To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
  • From: Kip Macy <kip.macy@xxxxxxxxx>
  • Date: Sun, 8 May 2005 16:17:48 -0700
  • Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Sun, 08 May 2005 23:17:23 +0000
  • Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=F4ushf63BBFxhc3YZA0m9EVL6z49zOTbltBl812EaZt9lICW+p/Sms0+0+qMK1KpOokEnDSiyxaY5Zc6mHvf8d1kc6Tu+E9+0ykI7v6ppdDjCqc5P5gLegqfCLpVyKT7moVrH1ibqiOsi4WqIUFNVRBoFTLHj1uFxfsHwFIcKbA=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

That seems reasonable - but I find its lack of uniformity a bit grating. 

Maybe instead of having the current domain be first fit, we could add
a "next_domid" field. That way when "xm list" and the like want to
enumerate, provided they start zero, they can keep querying until
next_domid == -1. I can't think of a case when one wouldn't enumerate
the domains starting at zero. So, at least superficially, it seems
like a reasonable alternative.

I'm willing to accept the possiblity that I'm just nitpicking so I
won't push it.


On 5/8/05, Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> wrote:
> On 8 May 2005, at 22:39, Kip Macy wrote:
> > One of the things that I've always thought was weird, but didn't pay
> > too close attention to is the fact that GETDOMAININFO will return a
> > valid result even if we give it a domid that is no longer valid.
> > Looking at the code we get back the first valid domain after the domid
> > we pass in.
> >
> > What is the reason for this design choice? When I request the
> > attributes of a process I don't get the attributes for the next pid up
> > with a pid field set to the process id of the process I actually got
> > the attributes for.
> Easy enumeration when we don't know which domain id's are in use. There
> are other ways to allow for enumeration that might be neater.
>   -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.