[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] warn when iproute2 or bridge-utils are missing

Isn't it more appropriate to have these be install-time checks?

It seems wasteful to check for an installed program every time a script is run. I submitted check scripts for iproute2 and iptables a while ago.

All you have to do is add a check_iproute2 script to the tools/check directory that basically looks like:

which ip || (echo "Check for iproute2 failed && exit 1)

Anthony Liguori

Scott Parish wrote:

On Fri, Feb 25, 2005 at 03:22:58PM -0500, Matt Ayres wrote:

On Fri, 2005-02-25 at 19:08 +0000, Scott Parish wrote:
The attached patch checks for "ip" and "brctl" in the path, and warns
the user if they are not found.

Now that the routed setup is included (and IMHO works a whole lot
better) shouldn't the brctl check be optional somehow?

Maybe what i started to do would be better then: make sure that output
from the scripts gets sent to the console in addition to getting buried
in the log file. Then have the scripts check that the programs that they
need are available (before fiddling with the network and putting it in a
half way state).


SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.