[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: [Xen-changelog] Some functions aren't static and could be (damn C language!).

On Tue, Feb 08, 2005 at 03:43:01PM +0000, BitKeeper Bot wrote:
> ChangeSet 1.1550.1.180, 2005/02/08 15:43:01+00:00, iap10@xxxxxxxxxxxxxxxxxxxxx
>       Some functions aren't static and could be (damn C language!).
>       I tried turning on -Wmissing-prototypes: unfortunately gives warnings
>       for functions used in asm, which means introducing gratuitous prototypes
>       for them.  Not sure it's worth it.
>       1) keyhandler.c: keypress_softirq() and do_task_queues() can be static.
>       2) physdev.c: pcidev_dom0_hidden() can be static.
>       3) resource.c/resource.h: check_region is deprecated (racy): remove.
>       4) sched_bvt.c: lots of things can be static.
>       5) pci/compat.c: not required for Xen.
>       Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx> (authored)
>       Signed-off-by: ian.pratt@xxxxxxxxxxxx

gah, that is not C language problem. that's lame.
you forced compiler to check prototypes so do add them. just add prototypes
even in the same .c file if you don't want to pollute your include files.
but if function is used anywhere outside file scope it is proper to describe it
in include file.

or don't use -Wmissing-prototypes.

SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.