[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Trivial fix for latent bug in page_alloc.c

Rusty Russell wrote:
@@ -251,17 +249,18 @@
    int i;
    struct pfn_info *pg;

-    if ( unlikely(order < MIN_ORDER) || unlikely(order > MAX_ORDER) )
+    ASSERT(order >= 0);
+    if ( unlikely(order >= MAX_ORDER) )
        return NULL;

Also changing > to >= is wrong.

Well, it's consistent with the rest of the patch.

How so? 'order == MAX_ORDER' is possible and valid, unless MAX_ORDER is

David Hopwood <david.nospam.hopwood@xxxxxxxxxxxxxxxx>

This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl
Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.