[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: [Xen-changelog] Header and EXPORT_SYMBOL() fixes so that more stuff builds.

  • To: Xen Development List <xen-devel@xxxxxxxxxxxxxxxxxxxxx>
  • From: Rik van Riel <riel@xxxxxxxxxx>
  • Date: Wed, 1 Dec 2004 16:07:21 -0500 (EST)
  • Delivery-date: Wed, 01 Dec 2004 21:08:36 +0000
  • List-id: List for Xen developers <xen-devel.lists.sourceforge.net>

On Wed, 1 Dec 2004, BitKeeper Bot wrote:

--- a/xen/include/public/xen.h  2004-12-01 05:00:51 -05:00
+++ b/xen/include/public/xen.h  2004-12-01 05:00:51 -05:00
@@ -9,8 +9,10 @@

+#ifndef PACKED
/* GCC-specific way to pack structure definitions (no implicit padding). */
#define PACKED __attribute__ ((packed))

That's not taking away the compile errors in befs, because
the befs header files are included _after_ the Xen ones.
Wonder if we should put a similar ifdef in there, or just
not care about befs ;)))

In file included from fs/befs/befs.h:11,
                 from fs/befs/linuxvfs.c:19:
fs/befs/befs_fs_types.h:21:1: warning: "PACKED" redefined
In file included from include/asm-xen/asm/page.h:18,
                 from include/asm/thread_info.h:13,
                 from include/linux/thread_info.h:21,
                 from include/linux/spinlock.h:12,
                 from include/linux/capability.h:45,
                 from include/linux/sched.h:7,
                 from include/linux/module.h:10,
                 from fs/befs/linuxvfs.c:8:
include/asm-xen/xen-public/xen.h:14:1: warning: this is the location of the 
previous definition

"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan

SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. http://productguide.itmanagersjournal.com/
Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.