[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 05/18] fix missing annotations


  • To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Césaire Mounah <cesaire.mounah@xxxxxxxxxx>
  • Date: Fri, 16 Oct 2026 15:26:42 +0200
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID"
  • Cc: Césaire Mounah <cesaire.mounah@xxxxxxxxxx>
  • Delivery-date: Fri, 16 Oct 2026 13:27:08 +0000
  • Feedback-id: default:8631fc262581453bbf619ec5b2062170:Sweego
  • List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>

* Fix missed annotations of macro-defined functions
* Fix functions with missing annotations

Signed-off-by: Césaire Mounah <cesaire.mounah@xxxxxxxxxx>
---
 src/xencrsh/pdo.c     | 5 +++--
 src/xencrsh/store.c   | 4 ++--
 src/xenvbd/adapter.c  | 4 ++--
 src/xenvbd/frontend.c | 8 ++++----
 src/xenvbd/registry.c | 4 ++--
 src/xenvbd/target.c   | 2 +-
 6 files changed, 14 insertions(+), 13 deletions(-)

diff --git a/src/xencrsh/pdo.c b/src/xencrsh/pdo.c
index 3ab4ba0..fa66172 100644
--- a/src/xencrsh/pdo.c
+++ b/src/xencrsh/pdo.c
@@ -302,8 +302,9 @@ VirtToPfn(
     PHYSICAL_ADDRESS    PhysAddr = MmGetPhysicalAddress(VirtAddr);
     return (PFN_NUMBER)(PhysAddr.QuadPart >> PAGE_SHIFT);
 }
-static FORCEINLINE ULONG __SectorSize(
-    IN  PXENVBD_PDO             Pdo
+static FORCEINLINE ULONG 
+__SectorSize(
+    _In_ PXENVBD_PDO    Pdo
     )
 {
     ASSERT3U(Pdo->Frontend.SectorSize, !=, 0);
diff --git a/src/xencrsh/store.c b/src/xencrsh/store.c
index 1f64dfd..8da61e8 100644
--- a/src/xencrsh/store.c
+++ b/src/xencrsh/store.c
@@ -355,10 +355,10 @@ StoreReceiveSegment(
 
 static FORCEINLINE BOOLEAN
 __StoreVerifyHeader(
-    struct xsd_sockmsg  *Header
+    _In_ struct xsd_sockmsg *Header
     )
 {
-    BOOLEAN             Valid;
+    BOOLEAN                 Valid;
 
     Valid = TRUE;
 
diff --git a/src/xenvbd/adapter.c b/src/xenvbd/adapter.c
index beffcff..8eab1f2 100644
--- a/src/xenvbd/adapter.c
+++ b/src/xenvbd/adapter.c
@@ -2312,8 +2312,8 @@ fail1:
 #define ADAPTER_GET_INTERFACE(_name, _type)                     \
 VOID                                                            \
 AdapterGet ## _name ## Interface(                               \
-    IN  PXENVBD_ADAPTER Adapter,                                \
-    OUT _type           _name ## Interface                      \
+    _In_ PXENVBD_ADAPTER    Adapter,                            \
+    _Out_ _type             _name ## Interface                  \
     )                                                           \
 {                                                               \
     * ## _name ## Interface = Adapter-> ## _name ## Interface;  \
diff --git a/src/xenvbd/frontend.c b/src/xenvbd/frontend.c
index a5e2236..d75e702 100644
--- a/src/xenvbd/frontend.c
+++ b/src/xenvbd/frontend.c
@@ -118,14 +118,14 @@ __XenvbdStateName(
 #define FRONTEND_GET_PROPERTY(_name, _type)     \
 static FORCEINLINE _type                        \
 __FrontendGet ## _name ## (                     \
-    IN  PXENVBD_FRONTEND    Frontend            \
+    _In_ PXENVBD_FRONTEND   Frontend            \
     )                                           \
 {                                               \
     return Frontend-> ## _name ## ;             \
 }                                               \
 _type                                           \
 FrontendGet ## _name ## (                       \
-    IN  PXENVBD_FRONTEND    Frontend            \
+    _In_ PXENVBD_FRONTEND   Frontend            \
     )                                           \
 {                                               \
     return __FrontendGet ## _name ## (Frontend);\
@@ -135,14 +135,14 @@ FrontendGet ## _name ## (                       \
 #define FRONTEND_GET_PROPERTY_PTR(_name, _type) \
 static FORCEINLINE _type                        \
 __FrontendGet ## _name ## (                     \
-    IN  PXENVBD_FRONTEND    Frontend            \
+    _In_ PXENVBD_FRONTEND   Frontend            \
     )                                           \
 {                                               \
     return &Frontend-> ## _name ## ;            \
 }                                               \
 _type                                           \
 FrontendGet ## _name ## (                       \
-    IN  PXENVBD_FRONTEND    Frontend            \
+    _In_ PXENVBD_FRONTEND   Frontend            \
     )                                           \
 {                                               \
     return __FrontendGet ## _name ## (Frontend);\
diff --git a/src/xenvbd/registry.c b/src/xenvbd/registry.c
index 080b200..3efff22 100644
--- a/src/xenvbd/registry.c
+++ b/src/xenvbd/registry.c
@@ -1398,7 +1398,7 @@ fail1:
 _IRQL_requires_(PASSIVE_LEVEL)
 static PKEY_VALUE_PARTIAL_INFORMATION
 RegistryAnsiToSz(
-    PANSI_STRING                    Ansi
+    _In_ PANSI_STRING               Ansi
     )
 {
     ULONG                           Length;
@@ -1445,7 +1445,7 @@ fail1:
 _IRQL_requires_(PASSIVE_LEVEL)
 static PKEY_VALUE_PARTIAL_INFORMATION
 RegistryAnsiToMultiSz(
-    PANSI_STRING                    Ansi
+    _In_ PANSI_STRING               Ansi
     )
 {
     ULONG                           Length;
diff --git a/src/xenvbd/target.c b/src/xenvbd/target.c
index 0051e90..0ba09cb 100644
--- a/src/xenvbd/target.c
+++ b/src/xenvbd/target.c
@@ -1587,7 +1587,7 @@ TargetDestroy(
 #define TARGET_GET_PROPERTY(_name, _type)       \
 _type                                           \
 TargetGet ## _name ## (                         \
-    IN  PXENVBD_TARGET  Target                  \
+    _In_ PXENVBD_TARGET Target                  \
     )                                           \
 {                                               \
     return Target-> ## _name ## ;               \
-- 
2.55.0.windows.5



--
Césaire Mounah | Vates Windows Guest Tools Engineer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.