[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add VIF interface V11


  • To: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Owen Smith <owen.smith@xxxxxxxxxx>
  • Date: Thu, 15 Oct 2026 08:25:29 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kYZHnLzgkNwCirTF3UY54KJTDC/HUCgfm8WL7XOFosg=; b=L12o9yWpL0nknXb/j5ZhZtHUgF8iMzA/wwn6Cfe3GP5GSqANE8oZhy6TpzHHTcrBcITStcon077q0Q5K4xPKJC2PPyHa9Zn11PBAlH4z6UX0TENG+JmUKkisnopK6ELzjatZu1HKoL8uOm7E0sOiLnitYoGjC5XoQSDRFNfG/nsulBD0sukkqoGx/PlfIfxxLLw31nnvEpYllyCwswJlUxZ0fmDWlLaqTmH8G1MOMhEi4SJJuNaEO6vlOTwfi3yjsb43SdRA1uW9KyVplVVrrisGjf+zl6NW0uVyHsITHCpC2XaK/bZ3HBsGRm2VqcAyULwVX9LOb+pzBJBrN5laIA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uKvxuWBloJrI7i3bXpdLU5nHgn25BCDr9mhHjKj0/R0ucggmPrwi182XKVhX8KtkqR+4rE170CqAUVIaEjOPhcrFLtnjk+wZubbgfBA/hZPkbCXDS/90AYuSw2vgGaCzkW5UEHmpok/KrnliZh+ydMs1yN8T8N/5LWZmh6+Ftzc6P+oNjQ6keLVzJqWAKZHCQAYZCU6uSbUaScKtYmS3enEbYTyVdRbczKa3DEvUeopaXmUAJEEu0h3eRV663+9d9eHrqXV28mP0NVCsoFZrctQ1CLPP+eJvnqQ2OYF1D5astVhVv6j4tXFy3PE+iAjZ3M9BRgfs2VyQZDAJZj1o4Q==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
  • Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Delivery-date: Thu, 15 Oct 2026 08:25:37 +0000
  • List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
  • Msip_labels:
  • Thread-index: AQHdW8SCxYPnrdFDPE6PBp48ejo2u7b+RQwX
  • Thread-topic: [PATCH] Add VIF interface V11

> 
> diff --git a/include/vif_interface.h b/include/vif_interface.h
> index cc2f626..66053a1 100644
> --- a/include/vif_interface.h
> +++ b/include/vif_interface.h
> @@ -567,17 +567,32 @@ typedef NTSTATUS
>      _Out_ PULONGLONG            Value
>      );
> 
> +/*! \typedef XENVIF_VIF_QUERY_RING_COUNT_V8
> +    \brief Query the number of shared rings between frontend
> +    and backend
> +
> +    \param Interface The interface header
> +    \param Count Buffer to receive the count
> +*/
> +typedef VOID
> +(*XENVIF_VIF_QUERY_RING_COUNT_V8)(
> +    _In_ PINTERFACE Interface,
> +    _Out_ PULONG    Count
> +    );
> +
>  /*! \typedef XENVIF_VIF_QUERY_RING_COUNT
>      \brief Query the number of shared rings between frontend
>      and backend
> 
>      \param Interface The interface header
>      \param Count Buffer to receive the count
> +    \param MaxCount Buffer to receive the maximum possible ring count
>  */
>  typedef VOID
>  (*XENVIF_VIF_QUERY_RING_COUNT)(
>      _In_ PINTERFACE Interface,
> -    _Out_ PULONG    Count
> +    _Out_ PULONG    Count,
> +    _Out_ PULONG    MaxCount

If both Count and MaxCount were _Out_opt_, then the 1st patch in your xennet 
changes
wouldnt need the MaxRingCount value, and the 2nd patch wouldnt need the Dummy 
value.


>      );

Owen


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.