[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 0/6] Update SAL annotations in xenhid


  • To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Césaire Mounah <cesaire.mounah@xxxxxxxxxx>
  • Date: Tue, 29 Sep 2026 19:05:07 +0200
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:Feedback-ID"
  • Cc: Césaire Mounah <cesaire.mounah@xxxxxxxxxx>
  • Delivery-date: Tue, 29 Sep 2026 17:05:55 +0000
  • Feedback-id: default:8631fc262581453bbf619ec5b2062170:Sweego
  • List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>

Update old annotations in the xenhid driver to use SAL 2.0, 
improving code analysis and correctness.

This update follows prior work on xenbus.[1]

The series has 3 parts:

Part 1: Convert all annotations to SAL 2.0
* xenhid: Convert all annotations to SAL 2.0
* Fix annotations on some parameters

Part 2: Update typedefs for better type safety
* Update string typedefs

Part 3: Fix new warnings introduced by SAL 2.0
* util: sync with xenbus util.h
* driver: fix annotations
* fdo: suppress warning on *Interface not being updated on success path

[1]: 
https://lists.xenproject.org/archives/html/win-pv-devel/2025-06/msg00049.html

Césaire Mounah (6):
  xenhid: Convert all annotations to SAL 2.0 for better code analysis
  Fix annotations on some parameters
  Update string typedefs
  util: sync with xenbus util.h
  driver: fix annotations
  fdo: suppress warning on *Interface not being updated on success path

 src/xenhid/assert.h    |  28 +++----
 src/xenhid/dbg_print.h |  20 ++---
 src/xenhid/driver.c    |  20 ++---
 src/xenhid/fdo.c       | 168 +++++++++++++++++++++--------------------
 src/xenhid/fdo.h       |  12 +--
 src/xenhid/names.h     |  18 ++---
 src/xenhid/string.c    |  28 +++----
 src/xenhid/string.h    |  10 +--
 src/xenhid/thread.c    |  28 +++----
 src/xenhid/thread.h    |  18 ++---
 src/xenhid/util.h      |  94 +++++++++++++----------
 11 files changed, 231 insertions(+), 213 deletions(-)

-- 
2.55.0.windows.5



--
Césaire Mounah | Vates Windows Guest Tools Engineer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.