Re: [PATCH] xenvif: fix TX doorbell coalescing - More overridden for non-RSS traffic

[Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>]

On 17/09/2026 17:45, david ambu wrote:
>    TransmitterQueuePacket unconditionally set More = FALSE in the
>    XENVIF_PACKET_HASH_ALGORITHM_NONE case, overriding the More value
>    passed in from xennet regardless of batch depth.

Could you unindent the commit message?

> 
> Assisted-by: ClaudeCode:claude-opus-4.8
> Signed-off-by: david ambu <david.preetham@xxxxxxxxxx>

With that changed:

Reviewed-by: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>

> ---
>   src/xenvif/transmitter.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/src/xenvif/transmitter.c b/src/xenvif/transmitter.c
> index 8c4ee41..ad58336 100644
> --- a/src/xenvif/transmitter.c
> +++ b/src/xenvif/transmitter.c
> @@ -5245,7 +5245,6 @@ TransmitterQueuePacket(
>       switch (Algorithm) {
>       case XENVIF_PACKET_HASH_ALGORITHM_NONE:
>           Value = __TransmitterHashPacket(Transmitter, Packet);
> -        More = FALSE;
>           break;
>   
>       case XENVIF_PACKET_HASH_ALGORITHM_UNSPECIFIED:



--
Ngoc Tu Dinh | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech