Re: [PATCH v2 3/3] xenbus/cache: spill slabs on CacheFill failure to prevent pool leak

[Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>]

On 14/09/2026 12:18, david ambu wrote:
> Call CacheSpill on the fail path in CacheFill to release any slabs
> already allocated before the failure, preventing a NonPagedPool leak.
> 
> Assisted-by: ClaudeCode:claude-sonnet-4-6
> Signed-off-by: david ambu <david.preetham@xxxxxxxxxx>

The commit message would need to be updated to take the moving of 
CacheSpill into account.

With that done:

Reviewed-by: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>

> ---
>   src/xenbus/cache.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/xenbus/cache.c b/src/xenbus/cache.c
> index 90aea08..ae72464 100644
> --- a/src/xenbus/cache.c
> +++ b/src/xenbus/cache.c
> @@ -901,11 +901,11 @@ fail5:
>   
>       (*Cache)->MagazineCount = 0;
>   
> -    CacheSpill(*Cache, 0);
> -
>   fail4:
>       Error("fail4\n");
>   
> +    CacheSpill(*Cache, 0);
> +
>   fail3:
>       Error("fail3\n");
>   



--
Ngoc Tu Dinh | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech