Re: [PATCH 1/2] Compact reported IPv[4|6] address xenstore values

[Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>]

On 08/09/2026 08:55, Owen Smith wrote:
> Pass the index of IPv[4|6] into the FrontendDumpIPv[4|6]Address call, to
> zero-index the IP address dumps to each of the specific protocols. Otherwise,
> an adapter could report uncontiguous indexes across IPv4 and IPv6.
> This also avoids cases where the address table contains non-IPv[4|6] 
> addresses,
> skipping indexes into the xenstore data.
> 
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>

Reviewed-by: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>

> ---
>   src/xenvif/frontend.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/xenvif/frontend.c b/src/xenvif/frontend.c
> index b772349..bece661 100644
> --- a/src/xenvif/frontend.c
> +++ b/src/xenvif/frontend.c
> @@ -907,7 +907,7 @@ FrontendDumpAddressTable(
>           case AF_INET: {
>               status = FrontendDumpIPv4Address(Frontend,
>                                                Transaction,
> -                                             Index,
> +                                             IpVersion4Count,
>                                                Entry);
>               if (!NT_SUCCESS(status))
>                   goto fail4;
> @@ -918,7 +918,7 @@ FrontendDumpAddressTable(
>           case AF_INET6: {
>               status = FrontendDumpIPv6Address(Frontend,
>                                                Transaction,
> -                                             Index,
> +                                             IpVersion6Count,
>                                                Entry);
>               if (!NT_SUCCESS(status))
>                   goto fail4;



--
Ngoc Tu Dinh | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech