Re: [PATCH 1/2] Remove redundant RtlZeroMemory on CacheCreateSlab

[Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>]

On 06/08/2026 09:46, Owen Smith wrote:
> __CacheAllocate already returns zeroed memory, it is redundant to
> call RtlZeroMemory after allocation.
> 
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>

Reviewed-by: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>

> ---
>   src/xenbus/cache.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/src/xenbus/cache.c b/src/xenbus/cache.c
> index eb7020d..81cd3eb 100644
> --- a/src/xenbus/cache.c
> +++ b/src/xenbus/cache.c
> @@ -424,8 +424,6 @@ CacheCreateSlab(
>       if (Slab == NULL)
>           goto fail2;
>   
> -    RtlZeroMemory(Slab, NumberOfBytes);
> -
>       Slab->Magic = XENBUS_CACHE_SLAB_MAGIC;
>       Slab->Cache = Cache;
>   



--
Ngoc Tu Dinh | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech