Re: [PATCH 3/3] Report IP network prefix in XenStore

[Owen Smith <owen.smith@xxxxxxxxxx>]

> @@ -735,7 +761,7 @@ FrontendDumpIPv6Address(
>      _In_ PXENVIF_ADDRESS            Entry
>      )
>  {
> -    CHAR                            Node[sizeof ("ipv6/XXXXXXXXXX")];
> +    CHAR                            Node[sizeof ("ipv6/XXXXXXXXXX/prefix")];
>      ULONG                           Index;
>      ULONG                           Count;
>      ULONG                           ZeroIndex;
> @@ -823,6 +849,26 @@ FrontendDumpIPv6Address(
>      if (!NT_SUCCESS(status))
>          return status;
> 
> +    if (Entry->Prefix > 128)
> +        return STATUS_SUCCESS;
> +
> +    status = RtlStringCbPrintfA(Node,
> +                                sizeof (Node),
> +                                "ipv6/%u/prefix",
> +                                AddressIndex);
> +    if (!NT_SUCCESS(status))
> +        return status;
> +
> +    status = XENBUS_STORE(Printf,
> +                          &Frontend->StoreInterface,
> +                          Transaction,
> +                          __FrontendGetPrefix(Frontend),
> +                          Node,
> +                          "%hhu",
> +                          Entry->Prefix);
> +    if (!NT_SUCCESS(status))
> +        return status;
> +
>      return STATUS_SUCCESS;
>  }

Is it intentional to potentially leave a 'prefix' value if Prefix <= 128?
Should "ipv6/%u/prefix" value be removed if Entry->Prefix <= 128

Owen