Re: [XENNET PATCH] Remove stubs for optional miniport handlers

[Owen Smith <owen.smith@xxxxxxxxxx>]

Reviewed-by: Owen Smith <owen.smith@xxxxxxxxx>

________________________________________
From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> on behalf of Tu 
Dinh <ngoc-tu.dinh@xxxxxxxxxx>
Sent: 08 October 2025 1:55 PM
To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
Cc: Tu Dinh; Owen Smith
Subject: [XENNET PATCH] Remove stubs for optional miniport handlers

MiniportCheckForHangEx, MiniportResetEx, MiniportDirectOidRequest and
MiniportCancelDirectOidRequest are not required by NDIS.

Just don't provide the handlers instead of providing stub do-nothing
handlers.

Signed-off-by: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>
---
 src/xennet/miniport.c | 59 -------------------------------------------
 1 file changed, 59 deletions(-)

diff --git a/src/xennet/miniport.c b/src/xennet/miniport.c
index 250b090..3ec76a9 100644
--- a/src/xennet/miniport.c
+++ b/src/xennet/miniport.c
@@ -222,35 +222,6 @@ MiniportCancelSend(
     UNREFERENCED_PARAMETER(CancelId);
 }

-static
-_Function_class_(MINIPORT_CHECK_FOR_HANG)
-BOOLEAN
-MiniportCheckForHangEx(
-    IN  NDIS_HANDLE MiniportAdapterContext
-    )
-{
-    UNREFERENCED_PARAMETER(MiniportAdapterContext);
-
-    return FALSE;
-}
-
-static
-_Function_class_(MINIPORT_RESET)
-NDIS_STATUS
-MiniportResetEx(
-    IN  NDIS_HANDLE MiniportAdapterContext,
-    OUT PBOOLEAN    AddressingReset
-    )
-{
-    UNREFERENCED_PARAMETER(MiniportAdapterContext);
-
-    Trace("<===>\n");
-
-    *AddressingReset = FALSE;
-
-    return NDIS_STATUS_SUCCESS;
-}
-
 static
 _Function_class_(MINIPORT_DEVICE_PNP_EVENT_NOTIFY)
 VOID
@@ -299,32 +270,6 @@ MiniportCancelOidRequest(
     Trace("<===>\n");
 }

-static
-_Function_class_(MINIPORT_DIRECT_OID_REQUEST)
-NDIS_STATUS
-MiniportDirectOidRequest(
-    IN  NDIS_HANDLE         MiniportAdapterContext,
-    IN  PNDIS_OID_REQUEST   OidRequest
-    )
-{
-    UNREFERENCED_PARAMETER(MiniportAdapterContext);
-    UNREFERENCED_PARAMETER(OidRequest);
-
-    return NDIS_STATUS_INVALID_OID;
-}
-
-static
-_Function_class_(MINIPORT_CANCEL_DIRECT_OID_REQUEST)
-VOID
-MiniportCancelDirectOidRequest(
-    IN  NDIS_HANDLE MiniportAdapterContext,
-    IN  PVOID       RequestId
-    )
-{
-    UNREFERENCED_PARAMETER(MiniportAdapterContext);
-    UNREFERENCED_PARAMETER(RequestId);
-}
-
 NDIS_STATUS
 MiniportRegister(
     IN  PDRIVER_OBJECT                      DriverObject,
@@ -366,20 +311,16 @@ MiniportRegister(

     MiniportDriverCharacteristics.CancelOidRequestHandler = 
MiniportCancelOidRequest;
     MiniportDriverCharacteristics.CancelSendHandler = MiniportCancelSend;
-    MiniportDriverCharacteristics.CheckForHangHandlerEx = 
MiniportCheckForHangEx;
     MiniportDriverCharacteristics.InitializeHandlerEx = MiniportInitializeEx;
     MiniportDriverCharacteristics.HaltHandlerEx = MiniportHaltEx;
     MiniportDriverCharacteristics.OidRequestHandler = MiniportOidRequest;
     MiniportDriverCharacteristics.PauseHandler = MiniportPause;
     MiniportDriverCharacteristics.DevicePnPEventNotifyHandler  = 
MiniportDevicePnPEventNotify;
-    MiniportDriverCharacteristics.ResetHandlerEx = MiniportResetEx;
     MiniportDriverCharacteristics.RestartHandler = MiniportRestart;
     MiniportDriverCharacteristics.ReturnNetBufferListsHandler = 
MiniportReturnNetBufferLists;
     MiniportDriverCharacteristics.SendNetBufferListsHandler = 
MiniportSendNetBufferLists;
     MiniportDriverCharacteristics.ShutdownHandlerEx = MiniportShutdownEx;
     MiniportDriverCharacteristics.UnloadHandler = MiniportDriverUnload;
-    MiniportDriverCharacteristics.DirectOidRequestHandler = 
MiniportDirectOidRequest;
-    MiniportDriverCharacteristics.CancelDirectOidRequestHandler = 
MiniportCancelDirectOidRequest;

     NdisStatus = NdisMRegisterMiniportDriver(DriverObject,
                                              RegistryPath,
--
2.51.0.windows.1



--
Ngoc Tu Dinh | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech