Re: [PATCH] Add CodeAnalysis switch to build.ps1

["Tu Dinh" <ngoc-tu.dinh@xxxxxxxxxx>]

Hello,

On 08/09/2025 09:47, Owen Smith wrote:
> Add option to enable code analysis on builds, so that developers can
> get code analysis feedback quicker than relying on SDV builds.
> 
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxx>

This and all similar patches:

Reviewed-by: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>

> ---
>   build.ps1   | 6 ++++--
>   msbuild.ps1 | 7 ++++---
>   2 files changed, 8 insertions(+), 5 deletions(-)
> 
> diff --git a/build.ps1 b/build.ps1
> index 4ff02c1..42bbdde 100644
> --- a/build.ps1
> +++ b/build.ps1
> @@ -8,7 +8,8 @@ param(
>       [string]$Arch,
>       [string]$SignMode = "TestSign",
>       [switch]$CodeQL,
> -     [switch]$Sdv
> +     [switch]$Sdv,
> +     [switch]$CodeAnalysis
>   )
>   
>   #
> @@ -30,7 +31,8 @@ Function Build {
>               ConfigurationBase = $configurationbase[$visualstudioversion];
>               Arch = $Arch;
>               Type = $Type;
> -             SignMode = $SignMode
> +             SignMode = $SignMode;
> +             CodeAnalysis = $CodeAnalysis
>               }
>       & ".\msbuild.ps1" @params
>       if ($LASTEXITCODE -ne 0) {
> diff --git a/msbuild.ps1 b/msbuild.ps1
> index 136cca8..6f55a5f 100644
> --- a/msbuild.ps1
> +++ b/msbuild.ps1
> @@ -8,7 +8,8 @@ param(
>       [string]$Arch,
>       [Parameter(Mandatory = $true)]
>       [string]$Type,
> -     [string]$SignMode = "TestSign"
> +     [string]$SignMode = "TestSign",
> +     [switch]$CodeAnalysis
>   )
>   
>   Function Run-MSBuild {
> @@ -154,10 +155,10 @@ $projectlist = @( "xencons" )
>   Set-ExecutionPolicy -Scope CurrentUser -Force Bypass
>   
>   if ($Type -eq "free") {
> -     Run-MSBuild $solutionpath "xencons.sln" $configuration["free"] 
> $platform[$Arch]
> +     Run-MSBuild $solutionpath "xencons.sln" $configuration["free"] 
> $platform[$Arch] -CodeAnalysis:$CodeAnalysis
>   }
>   elseif ($Type -eq "checked") {
> -     Run-MSBuild $solutionpath "xencons.sln" $configuration["checked"] 
> $platform[$Arch]
> +     Run-MSBuild $solutionpath "xencons.sln" $configuration["checked"] 
> $platform[$Arch] -CodeAnalysis:$CodeAnalysis
>   }
>   elseif ($Type -eq "codeql") {
>       if (-Not (Test-Path -Path $archivepath)) {



--
Ngoc Tu Dinh | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech