Re: [PATCH 2/2] Suppress prefast warning 6385

["Tu Dinh" <ngoc-tu.dinh@xxxxxxxxxx>]

On 05/09/2025 09:16, Owen Smith wrote:
> Force Activate patches added another location where the PhysicalDeviceObject
> array access generated a potential reading invalid data warning.
> 
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxx>
> ---
>   src/xenfilt/fdo.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/src/xenfilt/fdo.c b/src/xenfilt/fdo.c
> index ad57c95..04427bf 100644
> --- a/src/xenfilt/fdo.c
> +++ b/src/xenfilt/fdo.c
> @@ -464,6 +464,7 @@ FdoEnumerate(
>       for (Index = 0; Index < Count; Index++) {
>           ULONG   ThisPrecedence;
>   
> +#pragma warning(suppress:6385)  // Reading invalid data from 
> 'PhysicalDeviceObject'
>           if (PhysicalDeviceObject[Index] != NULL) {
>               status = DriverGetPrecedence(PhysicalDeviceObject[Index],
>                                            &ThisPrecedence);

I saw this warning during my tests, but was very confused on why it 
issued a warning in this case.

([PATCH 2/2] Suppress prefast warning 6385)

Acked-by: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>


--
Ngoc Tu Dinh | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech