Re: [XENVBD PATCH v6 14/15] Opt into forced unplug

[Owen Smith <owen.smith@xxxxxxxxx>]

Both patches

Reviewed-by: Owen Smith <owen.smith@xxxxxxxxx>

On Mon, Aug 18, 2025 at 8:41 AM Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx> wrote:

Condition the opt-in to the FORCE_UNPLUG build variable.

Signed-off-by: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>
---
 scripts/genfiles.ps1 | 2 ++
 src/xenvbd.inf       | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/scripts/genfiles.ps1 b/scripts/genfiles.ps1
index 85754c0..a7d13ae 100644
--- a/scripts/genfiles.ps1
+++ b/scripts/genfiles.ps1
@@ -70,6 +70,8 @@ $Replacements = [ordered]@{
        'MICRO_VERSION' = $Env:MICRO_VERSION;
        'BUILD_NUMBER' = $Env:BUILD_NUMBER;

+       'FORCE_UNPLUG' = $Env:FORCE_UNPLUG;
+
        # generated values
        'GIT_REVISION' = $GitRevision;

diff --git a/src/xenvbd.inf b/src/xenvbd.inf
index dfde613..0de71d1 100644
--- a/src/xenvbd.inf
+++ b/src/xenvbd.inf
@@ -106,6 +106,7 @@ HKR,"Parameters","multi-queue-max-queues",0x00010001,0x00000002

 [XenVbd_Unplug]
 HKLM,%UnplugKey%,"DISKS",0x00010001,0
+HKLM,%ForceUnplugKey%,"DISKS",0x00010001,1  ; @FORCE_UNPLUG@

 [XenVbd_Extras]
 HKLM,%PnpKey%,"DisableCDDB",0x00010001,0
@@ -120,6 +121,7 @@ DiskDesc = "@PRODUCT_NAME@ PV Storage Host Adapter Package"
 XenVbdName= "@PRODUCT_NAME@ PV Storage Host Adapter"
 XenDiskName= "@PRODUCT_NAME@ PV Storage Filter"
 UnplugKey="SYSTEM\CurrentControlSet\Services\XEN\Unplug"
+ForceUnplugKey="SYSTEM\CurrentControlSet\Services\XEN\ForceUnplug"
 PnpKey="SYSTEM\CurrentControlSet\Control\Pnp"
 PartMgrKey="SYSTEM\CurrentControlSet\Services\PartMgr\Parameters"
 DiskKey="SYSTEM\CurrentControlSet\Services\Disk"
--
2.50.1.windows.1



Ngoc Tu Dinh | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech