Re: [XENVKBD PATCH] Merge all hardware IDs into one Models entry

[Owen Smith <owen.smith@xxxxxxxxx>]

All patches in this series

Reviewed-by: Owen Smith <owen.smith@xxxxxxxxx>

On Wed, Aug 20, 2025 at 10:16 AM Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx> wrote:

This makes sure that on driver installation, all supported hardware IDs
will be populated into the driver database, thus allowing the device ID
to be freely switched.

Bump the feature score to compensate for the resulting degradation of
identifier-match-type score.

Unlike Xenbus, the feature score bump can be reverted on next PDO
revision bump.

Signed-off-by: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>
---
 src/xenvkbd.inf | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/xenvkbd.inf b/src/xenvkbd.inf
index f7d3b18..33caa5f 100644
--- a/src/xenvkbd.inf
+++ b/src/xenvkbd.inf
@@ -53,15 +53,15 @@ xenvkbd.sys=0,,
 %Vendor%=Inst,NT@INF_ARCH@

 [Inst.NT@INF_ARCH@]
-; DisplayName          Section         DeviceID
-; -----------          -------         --------
-
-%XenVkbdName%          =XenVkbd_Inst,  XENBUS\VEN_@VENDOR_PREFIX@@VENDOR_DEVICE_ID@&DEV_VKBD&REV_0900000A
-%XenVkbdName%          =XenVkbd_Inst,  XENBUS\VEN_@VENDOR_PREFIX@0001&DEV_VKBD&REV_0900000A
-%XenVkbdName%          =XenVkbd_Inst,  XENBUS\VEN_@VENDOR_PREFIX@0002&DEV_VKBD&REV_0900000A
+%XenVkbdName%=XenVkbd_Inst,\
+XENBUS\VEN_@VENDOR_PREFIX@@VENDOR_DEVICE_ID@&DEV_VKBD&REV_0900000A,\
+XENBUS\VEN_@VENDOR_PREFIX@0001&DEV_VKBD&REV_0900000A,\
+XENBUS\VEN_@VENDOR_PREFIX@0002&DEV_VKBD&REV_0900000A

 [XenVkbd_Inst]
 CopyFiles=XenVkbd_Copyfiles
+; TODO: Remove during next PDO version bump
+FeatureScore=0xFE

 [XenVkbd_Copyfiles]
 xenvkbd.sys
--
2.50.1.windows.1



Ngoc Tu Dinh | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech