Re: [PATCH] Avoid AdapterDisable bugcheck on a disabled Adapter

["Tu Dinh" <ngoc-tu.dinh@xxxxxxxxxx>]

On 11/08/2025 08:59, Owen Smith wrote:
> MiniportShutdownEx maybe called when the miniport is in any state, including
> the Paused state after MiniportPause. Both MiniportPause and 
> MiniportShutdownEx
> call AdapterDisable. The first call will unregister the suspend callback, and
> the second call will bugcheck, as the SuspendCallbackLate handle is now NULL.
> 
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxx>
> ---
>   src/xennet/adapter.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/xennet/adapter.c b/src/xennet/adapter.c
> index 67ced3e..cbca7f0 100644
> --- a/src/xennet/adapter.c
> +++ b/src/xennet/adapter.c
> @@ -1964,7 +1964,8 @@ AdapterDisable(
>       IN  PXENNET_ADAPTER     Adapter
>       )
>   {
> -    ASSERT(Adapter->Enabled);
> +    if (!Adapter->Enabled)
> +        return;
>       Adapter->Enabled = FALSE;
>   
>       ReceiverDisable(Adapter->Receiver);

Thanks,

Reviewed-by: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>


Ngoc Tu Dinh | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech