Re: [PATCH] Fix __FrontendUpdateHash

[Paul Durrant <xadimgnik@xxxxxxxxx>]

On 25/11/2024 13:04, Tu Dinh wrote:
> Fix an issue where __FrontendUpdateHash tries to
> set controller hash algorithm to Toeplitz even if
> its hash parameter was set to
> XEN_NETIF_CTRL_HASH_ALGORITHM_NONE.
>
> Signed-off-by: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>
> ---
>   src/xenvif/frontend.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
Acked-by: Paul Durrant <paul@xxxxxxx>

> diff --git a/src/xenvif/frontend.c b/src/xenvif/frontend.c
> index dab0ebb..79b04fb 100644
> --- a/src/xenvif/frontend.c
> +++ b/src/xenvif/frontend.c
> @@ -1911,10 +1911,13 @@ __FrontendUpdateHash(
>       }
>   
>       status = ControllerSetHashAlgorithm(Controller,
> -                                        
> XEN_NETIF_CTRL_HASH_ALGORITHM_TOEPLITZ);
> +                                        Hash->Algorithm);
>       if (!NT_SUCCESS(status))
>           goto fail1;
>   
> +    if (Hash->Algorithm == XEN_NETIF_CTRL_HASH_ALGORITHM_NONE)
> +        goto done;
> +
>       status = ControllerSetHashMappingSize(Controller, Size);
>       if (!NT_SUCCESS(status))
>           goto fail2;