Re: [PATCH] Fix error path cleanup

["Durrant, Paul" <xadimgnik@xxxxxxxxx>]

On 19/05/2022 11:17, Owen Smith wrote:
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>
Good catch.

Acked-by: Paul Durrant <paul@xxxxxxx>

> ---
>   src/xenbus/fdo.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/src/xenbus/fdo.c b/src/xenbus/fdo.c
> index 48d381a..d08c518 100644
> --- a/src/xenbus/fdo.c
> +++ b/src/xenbus/fdo.c
> @@ -3389,7 +3389,10 @@ FdoCreateHole(
>   fail3:
>       Error("fail3\n");
>   
> -    __FdoDestroyMemoryHole(Fdo);
> +    if (Fdo->Mdl != NULL)
> +        __FdoDestroyMemoryHole(Fdo);
> +    else
> +        __FdoDestroyPciHole(Fdo);
>   
>   fail2:
>       Error("fail2\n");