Re: [PATCH] xenfilt: Move list pointer to next entry when pdo is missing

["Durrant, Paul" <xadimgnik@xxxxxxxxx>]

On 08/10/2021 14:22, Richard Turner wrote:
> The pointer to the list of fdo entries is never advanced
> when the pdo is missing, causing a BSOD. When a device
> is missing, advance the list pointer to the next entry.
>
> Signed-off-by: Richard Turner <turnerr@xxxxxxxxxxxx>
Acked-by: Paul Durrant <paul@xxxxxxx>

> ---
>   src/xenfilt/fdo.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/xenfilt/fdo.c b/src/xenfilt/fdo.c
> index b8cf424..6a45b0f 100644
> --- a/src/xenfilt/fdo.c
> +++ b/src/xenfilt/fdo.c
> @@ -1107,7 +1107,7 @@ FdoQueryDeviceRelations(
>                   if (PdoGetDevicePnpState(Pdo) == Deleted)
>                       PdoDestroy(Pdo);
>   
> -                continue;
> +                goto next;
>               }
>   
>               if (PdoGetDevicePnpState(Pdo) == Present)
> @@ -1116,6 +1116,7 @@ FdoQueryDeviceRelations(
>               ObReferenceObject(PdoGetPhysicalDeviceObject(Pdo));
>               Relations->Objects[Relations->Count++] = 
> PdoGetPhysicalDeviceObject(Pdo);
>   
> +next:
>               ListEntry = Next;
>           }
>