Re: [PATCH] Log module loading

[Paul Durrant <xadimgnik@xxxxxxxxx>]

On 13/07/2021 09:39, Martin Harvey wrote:
> I note that very close to the debug print that was changed, we have 
> INSERT_BEFORE and INSERT_AFTER macros. The positioning and existence of them 
> there seems a bit crazy - double linked list handling seems to be a general 
> thing that should either be handled by nt!Rtl___, nt!Ex___, or put in a common 
> file.
That sounds sensible. Please feel free to make this common code.

  Paul

> MH.
>
> -----Original Message-----
> From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of 
> Paul Durrant
> Sent: 12 July 2021 20:00
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH] Log module loading
>
> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments 
> unless you have verified the sender and know the content is safe.
>
> On 07/07/2021 09:54, Martin Harvey wrote:
> > From: Paul Durrant <paul.durrant@xxxxxxxxxx>
> >
> > Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> > ---
> >    src/xen/module.c | 5 +++++
> >    1 file changed, 5 insertions(+)
> >
> > diff --git a/src/xen/module.c b/src/xen/module.c index
> > 584a63d..9c4a5ea 100644
> > --- a/src/xen/module.c
> > +++ b/src/xen/module.c
> > @@ -145,6 +145,11 @@ ModuleAdd(
> >        BOOLEAN             After;
> >        NTSTATUS            status;
> >    
> > +    Info("%p - %p [%s]\n",
> Not necessarily sure we want to log at this level in the general case. I think 
> it would be reasonable for this to be a debug log line.
>
>     Paul
>
> > +         Start,
> > +         Start + Size - 1,
> > +         Name);
> > +
> >        New = __ModuleAllocate(sizeof (MODULE));
> >    
> >        status = STATUS_NO_MEMORY;