RE: [PATCH] Report reboot required via xenstore

[Owen Smith <owen.smith@xxxxxxxxxx>]

> -----Original Message-----
> From: Owen Smith <owen.smith@xxxxxxxxxx>
> Sent: 19 August 2020 08:39
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Owen Smith <owen.smith@xxxxxxxxxx>
> Subject: [PATCH] Report reboot required via xenstore
> 
> Report if the driver requires a reboot to xenstore, so that the toolstack can
> detect if a driver requires a reboot. This is useful if drivers are delivered 
> by
> Windows Update, or another hands-free method, that does not correctly
> manage reboots and the popup provided by xenbus_monitor is not sufficient to
> guarantee the reboot is visible (i.e. the VM is being run as a headless server
> without a visible user
> session)
> 
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>
> ---
>  src/xenvbd/adapter.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/src/xenvbd/adapter.c b/src/xenvbd/adapter.c index
> 5e20944..de78ac0 100644
> --- a/src/xenvbd/adapter.c
> +++ b/src/xenvbd/adapter.c
> @@ -501,8 +501,15 @@ __AdapterEnumerate(
> 
>      if (NeedInvalidate)
>          AdapterTargetListChanged(Adapter);
> -    if (NeedReboot)
> +    if (NeedReboot) {
> +        (VOID) XENBUS_STORE(Printf,
> +                            &Adapter->StoreInterface,
> +                            NULL,
> +                            "feature/reboot-required",
> +                            "xenvbd",

This should just be "vbd"

> +                            "1");
>          DriverRequestReboot();
> +    }
>  }
> 
>  static DECLSPEC_NOINLINE NTSTATUS
> --
> 2.16.2.windows.1