Re: mirage + ocaml4

[Pierre Chambart <pierre.chambart@xxxxxxxxxxxx>]

Le Wed, 12 Dec 2012 11:34:04 +0000,
Anil Madhavapeddy <anil@xxxxxxxxxx> a Ãcrit :

> One performance crime that I noticed is the Cstruct.blit_string
> function, which does a byte-by-byte copy from a string to a
> Bigarray.  Pierre, do you have any thoughts on how to improve this?
> A faster blit between them would be quite useful.

Of course it is possible to do a memcopy like for copy_string. I can do
this patch later today.

I noticed that the type t is public. This may be a good idea to make it
private in the mli to avoid dangerous usage. And you should then add
with that a cast function checking that the bounds are effectively
correct.

type t = private {
  buffer: buffer;
  off : int;
  len : int;
}

val check: buffer -> off:int -> len:int -> t

-- 
Pierre

Attachment: signature.asc
Description: PGP signature