Re: [Embedded-pv-devel] [Xen-devel] [PATCH RFC 15/18] arm: Add ability to relocate Xen in over 4GB space

[Julien Grall <julien.grall@xxxxxxx>]

Hello,

On 18/05/16 17:32, Andrii Anisov wrote:
> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
> index 48f734f..7e507bc 100644
> --- a/xen/arch/arm/setup.c
> +++ b/xen/arch/arm/setup.c
> @@ -394,9 +394,13 @@ static paddr_t __init get_xen_paddr(void)
>           const struct membank *bank = &mi->bank[i];
>           paddr_t s, e;
>
> +        //TODO: investigate reason why we need contiguous memory
> +        //and how it can affect relocation of Xen in over 4GB space
Xen ARM was not able to support sparse memory before Xen 4.5. I.e only 
contiguous banks were supported. Xen had to be relocated on those banks 
to avoid issues when the init memory was released.
I believe this is not necessary anymore. Can you send this fix in a 
separate patch?
> +#ifndef ARM32_RELOCATE_OVER_4GB
>           /* We can only deal with contiguous memory at the moment */
>           if ( last_end != bank->start )
>               break;
> +#endif
>
>           last_end = bank->start + bank->size;
Regards,

--
Julien Grall

_______________________________________________
Embedded-pv-devel mailing list
Embedded-pv-devel@xxxxxxxxxxxxxxxxxxxx
http://lists.xenproject.org/cgi-bin/mailman/listinfo/embedded-pv-devel