This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xense-devel] [PATCH] update for Trusted Boot v20071128

To: "Cihula, Joseph" <joseph.cihula@xxxxxxxxx>
Subject: Re: [Xense-devel] [PATCH] update for Trusted Boot v20071128
From: Atsushi SAKAI <sakaia@xxxxxxxxxxxxxx>
Date: Fri, 30 Nov 2007 11:54:38 +0900
Cc: "Wang, Shane" <shane.wang@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, xense-devel@xxxxxxxxxxxxxxxxxxx, "Wei, Gang" <gang.wei@xxxxxxxxx>
Delivery-date: Thu, 29 Nov 2007 18:55:52 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <D936D925018D154694D8A362EEB08920030FE06D@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xense-devel-request@lists.xensource.com?subject=help>
List-id: "A discussion list for those developing security enhancements for Xen." <xense-devel.lists.xensource.com>
List-post: <mailto:xense-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xense-devel>, <mailto:xense-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xense-devel>, <mailto:xense-devel-request@lists.xensource.com?subject=unsubscribe>
References: <D936D925018D154694D8A362EEB08920030FE06D@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xense-devel-bounces@xxxxxxxxxxxxxxxxxxx

I have just one question.
Currently Your patch supports version=0x01 only?
>From seeing tboot code, It seems 
0x01 for tboot-20071029
0x02 for tboot-20071128
I think it should fix the comment of "version" in tboot_shared_t.

Atsushi SAKAI

"Cihula, Joseph" <joseph.cihula@xxxxxxxxx> wrote:
>  typedef struct __attribute__ ((__packed__)) {
> +    /* version 0x01+ fields: */
>      uuid_t    uuid;              /*
> {663C8DFF-E8B3-4b82-AABF-19EA4D057A08} */
>      uint32_t  version;           /* 0x01 */
>      uint32_t  log_addr;          /* physical addr of tb_log_t log */
> @@ -59,6 +60,9 @@ typedef struct __attribute__ ((__packed_
>      uint32_t  s3_k_wakeup_entry; /* entry point for xen s3 wake up */
>      uint8_t   acpi_sinfo[MAX_TB_ACPI_SINFO_SIZE];
>                                   /* where kernel put acpi sleep info in
> Sx */
> +    /* version 0x02+ fields: */
> +    uint32_t  tboot_base;        /* starting addr for tboot */
> +    uint32_t  tboot_size;        /* size of tboot */
>  } tboot_shared_t;
>  #define TB_SHUTDOWN_REBOOT      0

Xense-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>