WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-users

Re: Re: [mdlabriola@xxxxxxxxx: [Xen-devel] Re: Re: [Xen-users] DomU rout

To: "Ian.Campbell@xxxxxxxxxx" <Ian.Campbell@xxxxxxxxxx>
Subject: Re: Re: [mdlabriola@xxxxxxxxx: [Xen-devel] Re: Re: [Xen-users] DomU routed traffic disappearing in vif.]
From: Matej Zary <zary@xxxxxxxxx>
Date: Tue, 11 May 2010 02:43:29 +0200
Accept-language: en-US
Acceptlanguage: en-US
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "xen-users@xxxxxxxxxxxxxxxxxxx" <xen-users@xxxxxxxxxxxxxxxxxxx>, "mdlabriola@xxxxxxxxx" <mdlabriola@xxxxxxxxx>, "konrad.wilk@xxxxxxxxxx" <konrad.wilk@xxxxxxxxxx>
Delivery-date: Wed, 02 Jun 2010 10:23:40 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1273505553.7572.561.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20100510151835.GG29517@xxxxxxxxxxxxxxxxxxx> <1273505553.7572.561.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acrwovl+1q3M0V1URaenE/SWbEfHag==
Thread-topic: Re: [mdlabriola@xxxxxxxxx: [Xen-devel] Re: Re: [Xen-users] DomU routed traffic disappearing in vif.]
On Mon, 2010-05-10 at 16:32 +0100, Ian Campbell wrote:
> On Mon, 2010-05-10 at 16:18 +0100, Konrad Rzeszutek Wilk wrote:
> > Ian had a patch that he backported from XCP that might fix this, not
> > sure thought. 
> 
> If possible can someone who is seeing this issue try this patch:
> 
> --- 
> 
> xen/netback: correctly setup skb->ip_summed on receive
> 
> In 2.6.18 CHECKSUM_PARTIAL and CHECKSUM_UNNECESSARY were both synonyms for
> CHECKSUM_HW. This is no longer the case and we need to select the correct one.
> 
>   data_validated csum_blank -> ip_summed
>   0              0             CHECKSUM_NONE
>   0              1             CHECKSUM_PARTIAL
>   1              0             CHECKSUM_UNNECESSARY
>   1              1             CHECKSUM_PARTIAL
> 
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> diff -r 3a1424756f50 drivers/xen/netback/netback.c
> --- a/drivers/xen/netback/netback.c   Fri May 07 14:38:37 2010 +0100
> +++ b/drivers/xen/netback/netback.c   Fri May 07 14:40:31 2010 +0100
> @@ -1384,14 +1384,10 @@
>                       netif_idx_release(pending_idx);
>               }
>  
> -             /*
> -              * Old frontends do not assert data_validated but we
> -              * can infer it from csum_blank so test both flags.
> -              */
> -             if (txp->flags & (NETTXF_data_validated|NETTXF_csum_blank))
> +             if (txp->flags & NETTXF_csum_blank)
>                       skb->ip_summed = CHECKSUM_PARTIAL;
> -             else
> -                     skb->ip_summed = CHECKSUM_NONE;
> +             else if (txp->flags & NETTXF_data_validated)
> +                     skb->ip_summed = CHECKSUM_UNNECESSARY;
>  
>               netbk_fill_frags(skb);
>  
> 
> 
Works for me!

The DomU router now works like charm. Thanks! :) Also the problem with
ICMP traffic disappeared (non UDP/TCP packet dropped in syslog).

Patched the 2.6.32.11 kernel, performance wise, the 2.6.18.8 had bit
better some numbers (~ 60 Mbit difference with Iperf), will have some
more numbers later. 

Regards

Matej

<<attachment: winmail.dat>>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
  • Re: Re: [mdlabriola@xxxxxxxxx: [Xen-devel] Re: Re: [Xen-users] DomU routed traffic disappearing in vif.], Matej Zary <=