WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-users

[Xen-users] RE: oprofile 0.9.3 xen symbols incorrect

To: "Santos, Jose Renato G" <joserenato.santos@xxxxxx>, <oprofile-list@xxxxxxxxxxxxxxxxxxxxx>, <xen-users@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-users] RE: oprofile 0.9.3 xen symbols incorrect
From: "Apparao, Padmashree K" <padmashree.k.apparao@xxxxxxxxx>
Date: Thu, 6 Mar 2008 22:05:26 -0800
Delivery-date: Tue, 11 Mar 2008 10:40:43 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C7B67062D31B9E459128006BAAD0DC3D0753EE10DA@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-users-request@lists.xensource.com?subject=help>
List-id: Xen user discussion <xen-users.lists.xensource.com>
List-post: <mailto:xen-users@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-users>, <mailto:xen-users-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-users>, <mailto:xen-users-request@lists.xensource.com?subject=unsubscribe>
References: <AF358A0C5B36EC4486D1A764A171904D02E1A661@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <C7B67062D31B9E459128006BAAD0DC3D0753EE10DA@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-users-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Ach/0YTdeNSXlLBYShOnvwg7vy3ZbAADx1WAAAvI+3AAAlgyMA==
Thread-topic: oprofile 0.9.3 xen symbols incorrect

Renato,

 

OOPs that patch kills the VM that is running L

 

-Padma

 

 

 


From: Santos, Jose Renato G [mailto:joserenato.santos@xxxxxx]
Sent: Thursday, March 06, 2008 9:22 PM
To: Apparao, Padmashree K; oprofile-list@xxxxxxxxxxxxxxxxxxxxx; xen-users@xxxxxxxxxxxxxxxxxxx
Subject: RE: oprofile 0.9.3 xen symbols incorrect

 

Padma,

 

I received some reports in the past that Xenoprof was generating incorrect symbols for HVM guests on Intel processors.

Here is a patch provided by Andrew Gallagher that should fix the problem but I did not have had a chance to test it yet. It has been sitting on my todo list for a long time.

Could you please check if this fix the problem and let me know.

 

Thanks

 

Renato

 

 

diff -r 0164d924ceba xen/arch/x86/hvm/vmx/vmx.c
--- a/xen/arch/x86/hvm/vmx/vmx.c Wed Feb 13 10:43:13 2008 +0000
+++ b/xen/arch/x86/hvm/vmx/vmx.c Thu Mar 06 21:08:46 2008 -0800
@@ -2511,6 +2511,7 @@ asmlinkage void vmx_vmexit_handler(struc
          * (2) NMI
          */
         unsigned int intr_info, vector;
+        int saved_eip;
 
         intr_info = __vmread(VM_EXIT_INTR_INFO);
         BUG_ON(!(intr_info & INTR_INFO_VALID_MASK));
@@ -2565,7 +2566,10 @@ asmlinkage void vmx_vmexit_handler(struc
                  (X86_EVENTTYPE_NMI << 8) )
                 goto exit_and_crash;
             HVMTRACE_0D(NMI, v);
+            saved_eip = regs->eip;
+            regs->eip = __vmread(GUEST_RIP);
             do_nmi(regs); /* Real NMI, vector 2: normal processing. */
+            regs->eip = saved_eip;
             break;
         case TRAP_machine_check:
             HVMTRACE_0D(MCE, v);

 

 


From: Apparao, Padmashree K [mailto:padmashree.k.apparao@xxxxxxxxx]
Sent: Thursday, March 06, 2008 3:21 PM
To: oprofile-list@xxxxxxxxxxxxxxxxxxxxx; Santos, Jose Renato G; xen-users@xxxxxxxxxxxxxxxxxxx
Subject: FW: oprofile 0.9.3 xen symbols incorrect

 

Hi

 

I am using oprofile 0.9.3 on xen cs 16540 on an Intel system.

 

When I look at the top “hot” functions, I see p2m_change_type being one of the top function in xen-syms. This function is only in the svm (AMD) code and should not appear on an Intel system. I see that this function is not being clled at all when I am running my apps as I have put printk in the functions and they do not show up anywhere in the dmesg.

 

Is it possible that oprofile is picking up the symbols from elsewhere? The /root/.profile/daemonrc file shows the correct xen-syms file, so obviously it is not using that..

 

(I am profiling a HVM domain using passive-domains in the command line for opcontrol)

 

Thanks

-Padma

 

 

 

 

 

 

 

_______________________________________________
Xen-users mailing list
Xen-users@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-users
<Prev in Thread] Current Thread [Next in Thread>