WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-users

Re: [Xen-users] Credit Scheduler!

To: "Hardeep Singh" <hardeepguru@xxxxxxxxx>, xen-users@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-users] Credit Scheduler!
From: "Hardeep Singh" <hardeepguru@xxxxxxxxx>
Date: Fri, 30 Jun 2006 11:24:51 -0500
Delivery-date: Fri, 30 Jun 2006 09:25:26 -0700
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references; b=UoQmfsRp1SnT+ZpBXQgc6RFFEQr8mTCU2RONN5CvByJ7yK7wLeOpAaAvZ7D18G5HxoLeQSKgYwMCr+bOXz0rq6UxLrhOsHYNsW9lbCeFlOBA/5CuOZEe/n3TjJM7noAIHbxpR6x+BEfD2pFhKrVJngGZ4ohW7hIDbVGSAb11fng=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20060630161649.GA23810@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-users-request@lists.xensource.com?subject=help>
List-id: Xen user discussion <xen-users.lists.xensource.com>
List-post: <mailto:xen-users@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-users>, <mailto:xen-users-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-users>, <mailto:xen-users-request@lists.xensource.com?subject=unsubscribe>
References: <77d78aa70606300749t4c3b32del9f4e5433be31db3e@xxxxxxxxxxxxxx> <20060630161649.GA23810@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-users-bounces@xxxxxxxxxxxxxxxxxxx
Oh! Thanks a lot. I know this sounds lame but can you tell me what do I need to do in order to run the patch :)

Regards,
Hardeep

On 6/30/06, Emmanuel Ackaouy <ack@xxxxxxxxxxxxx> wrote:
On Fri, Jun 30, 2006 at 09:49:57AM -0500, Hardeep Singh wrote:
>    root@pippin:/home/hardeep# xm sched-credit -d vm1 -w 10
>
>    (XEN) BUG at sched_credit.c:757

Ok I found the problem and submitted a fix to the staging
tree. It should trickle out to the public tree in a couple
hours when it's gone through the regression tests.

In the meantime, here's a patch if you don't want to wait.

diff -r 3dfc2583a4f1 xen/common/sched_credit.c
--- a/xen/common/sched_credit.c Thu Jun 29 16:59:47 2006 +0100
+++ b/xen/common/sched_credit.c Fri Jun 30 16:56:17 2006 +0100
@@ -622,9 +622,12 @@ csched_dom_cntl(

         if ( cmd->u.credit.weight != 0 )
         {
-            csched_priv.weight -= sdom->weight;
+            if ( !list_empty(&sdom->active_sdom_elem) )
+            {
+                csched_priv.weight -= sdom->weight;
+                csched_priv.weight += cmd->u.credit.weight;
+            }
             sdom->weight = cmd->u.credit.weight;
-            csched_priv.weight += sdom->weight;
         }

         if ( cmd->u.credit.cap != (uint16_t)~0U )



--
hardeep
_______________________________________________
Xen-users mailing list
Xen-users@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-users