> -----Original Message-----
> From: Keir Fraser [mailto:Keir.Fraser@xxxxxxxxxxxx]
> Sent: 01 June 2006 19:09
> To: Petersson, Mats
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxx; Puthiyaparambil, Aravindh;
> Uros Trebec; Ryan Harper; xen-users@xxxxxxxxxxxxxxxxxxx;
> Pablo Montesinos
> Subject: Re: [Xen-devel] RE: [Xen-users] Xen in a 32 way system
>
>
> On 1 Jun 2006, at 18:59, Petersson, Mats wrote:
>
> > Isn't it a bug that we don't check for -EINVAL in the line here:
> > for (i = 0; i < NR_CPUS; i++) {
> > rc = HYPERVISOR_vcpu_op(VCPUOP_is_up, i, NULL);
> > if (rc == -ENOENT)
> > break;
> > cpu_set(i, cpu_possible_map);
> > }
> >
> > If NR_CPUS in Linux is bigger than 32, then rc = -EINVAL,
> not -ENOENT
> > when it returns from the vcpu_op, because the first check
> is to see if
> > vcpuid is >=32...
> >
> > Checking if (rc < 0) would be better, I should think...
>
> Yes, the current code is rather mad. I'll fix it.
Of course, if NR_CPUS is 32, it shouldn't matter...
Pablo, can you check the CONFIG_NR_CPUS in your .config for your
linux-2.6.16.13-xen? As in my system, NR_CPUS = 32..
--
Mats
>
> -- Keir
>
>
>
_______________________________________________
Xen-users mailing list
Xen-users@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-users
|
Home