WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ppc-devel

Re: [XenPPC] libvirt bad paddr patch for our hcall.c

Christian Ehrhardt wrote:
[...]
diff -r 1139ab948449 arch/powerpc/platforms/xen/hcall.c
--- a/arch/powerpc/platforms/xen/hcall.c        Sun Jul 15 15:33:56 2007 +0200
+++ b/arch/powerpc/platforms/xen/hcall.c        Sun Aug 05 03:50:28 2007 +0200
@@ -437,6 +437,16 @@ out:
        return ret;
 }

+ if ( ((p & 0x00000000FFFFFFFFUL) == 0x0) + && ((p & 0xFFFFFFFF00000000UL) != 0x0) )
+               return 1;
+       else
+               return 0;
I just had a second look at it, since I got it down to the simple check in a separate function we could collapse the returns and the if to something like

+ return ( ((p & 0x00000000FFFFFFFFUL) == 0x0) + && ((p & 0xFFFFFFFF00000000UL) != 0x0) )



--

Grüsse / regards, Christian Ehrhardt

IBM Linux Technology Center, Open Virtualization
+49 7031/16-3385
Ehrhardt@xxxxxxxxxxxxxxxxxx
Ehrhardt@xxxxxxxxxx

IBM Deutschland Entwicklung GmbH
Vorsitzender des Aufsichtsrats: Johann Weihen Geschäftsführung: Herbert Kircher Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294


_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel

<Prev in Thread] Current Thread [Next in Thread>