[XenPPC] [PATCH] Fix Xen-GDB Stub (smp_sen_stop, E00 on unknown command, remove printk prefix)

[Christian Ehrhardt <ehrhardt@xxxxxxxxxxxxxxxxxx>]

[XEN][POWERPC] Fix Xen-GDB Stub (smp_sen_stop, E00 on unknown command, remove 
printk prefix)
- Remove BUG() from smp_stop_all(), common code changes added a call to this - 
changed to unimplemented().
- remove the printk prefix "(XEN) " when falling into gdb, because gdb tried to parse the 
"(XEN) " response sometimes
- return E00 on unknown command (thx to jimi)

Signed-off-by: Christian Ehrhardt <ehrhardt@xxxxxxxxxxxxxxxxxx>

diff -r 736f2d6d7b09 xen/arch/powerpc/smp.c
--- a/xen/arch/powerpc/smp.c    Fri Mar 02 18:05:38 2007 -0600
+++ b/xen/arch/powerpc/smp.c    Thu Apr 12 14:34:39 2007 +0200
@@ -68,7 +68,7 @@ int smp_call_function(void (*func) (void

void smp_send_stop(void)
{
-    BUG();
+    unimplemented();
}

struct call_data_struct {
diff -r 736f2d6d7b09 xen/common/gdbstub.c
--- a/xen/common/gdbstub.c      Fri Mar 02 18:05:38 2007 -0600
+++ b/xen/common/gdbstub.c      Thu Apr 12 14:34:40 2007 +0200
@@ -472,7 +472,7 @@ process_command(struct cpu_user_regs *re
    }

    default:
-        gdb_send_reply("", ctx);
+        gdb_send_reply("E00", ctx);
        break;
    }
    return resume;
@@ -554,6 +554,7 @@ __trap_to_gdb(struct cpu_user_regs *regs
    /* Shouldn't really do this, but otherwise we stop for no
       obvious reason, which is Bad */
    printk("Waiting for GDB to attach...\n");
+    set_printk_prefix("");

    gdb_arch_enter(regs);
    gdb_ctx->signum = gdb_arch_signal_num(regs, cookie);


--

Grüsse / regards, 
Christian Ehrhardt
IBM Linux Technology Center, Open Virtualization
+49 7031/16-3385
Ehrhardt@xxxxxxxxxxxxxxxxxxx
Ehrhardt@xxxxxxxxxx

IBM Deutschland Entwicklung GmbH
Vorsitzender des Aufsichtsrats: Johann Weihen 
Geschäftsführung: Herbert Kircher 
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294

diff -r 736f2d6d7b09 xen/arch/powerpc/smp.c
--- a/xen/arch/powerpc/smp.c    Fri Mar 02 18:05:38 2007 -0600
+++ b/xen/arch/powerpc/smp.c    Thu Apr 12 14:34:39 2007 +0200
@@ -68,7 +68,7 @@ int smp_call_function(void (*func) (void
 
 void smp_send_stop(void)
 {
-    BUG();
+    unimplemented();
 }
 
 struct call_data_struct {
diff -r 736f2d6d7b09 xen/common/gdbstub.c
--- a/xen/common/gdbstub.c      Fri Mar 02 18:05:38 2007 -0600
+++ b/xen/common/gdbstub.c      Thu Apr 12 14:34:40 2007 +0200
@@ -472,7 +472,7 @@ process_command(struct cpu_user_regs *re
     }
 
     default:
-        gdb_send_reply("", ctx);
+        gdb_send_reply("E00", ctx);
         break;
     }
     return resume;
@@ -554,6 +554,7 @@ __trap_to_gdb(struct cpu_user_regs *regs
     /* Shouldn't really do this, but otherwise we stop for no
        obvious reason, which is Bad */
     printk("Waiting for GDB to attach...\n");
+    set_printk_prefix("");
 
     gdb_arch_enter(regs);
     gdb_ctx->signum = gdb_arch_signal_num(regs, cookie);

_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel