WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ppc-devel

Re: [XenPPC] [PATCH] [RESEND] Xencomm patch

To: Jerone Young <jyoung5@xxxxxxxxxx>, "Hollis R. Blanchard" <hollisb@xxxxxxxxxx>
Subject: Re: [XenPPC] [PATCH] [RESEND] Xencomm patch
From: Jimi Xenidis <jimix@xxxxxxxxxxxxxx>
Date: Mon, 5 Feb 2007 07:15:24 -0500
Cc: xen-ppc-devel <xen-ppc-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 05 Feb 2007 04:14:45 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1170461448.24378.8.camel@thinkpad>
List-help: <mailto:xen-ppc-devel-request@lists.xensource.com?subject=help>
List-id: Xen PPC development <xen-ppc-devel.lists.xensource.com>
List-post: <mailto:xen-ppc-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1170456128.3419.8.camel@thinkpad> <1170461448.24378.8.camel@thinkpad>
Sender: xen-ppc-devel-bounces@xxxxxxxxxxxxxxxxxxx

On Feb 2, 2007, at 7:10 PM, Jerone Young wrote:

Sorry guys. Please ignore this patch. I found a bug with it. Will submit
a fixed version shortly.

Ok, took a peek though and it seems that not all xencomm_map*() calls have there return values checked. Using ENOSPC for the errno for xencomm_map_no_alloc() seems inappropriate, since it ENOSPC is really about devices. ENOMEM is not right because we are not trying to allocate. I do not think anything fits perfectly, but I'd go with EINVAL because argsize is simply to big and an invalid argument.
Thoughts?

-JX


_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel

<Prev in Thread] Current Thread [Next in Thread>