WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ppc-devel

[XenPPC] moving HYPERVISOR_grant_table_op may not be the best idea?

To: xen-ppc-devel <xen-ppc-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [XenPPC] moving HYPERVISOR_grant_table_op may not be the best idea?
From: Jerone Young <jyoung5@xxxxxxxxxx>
Date: Tue, 23 Jan 2007 10:23:14 -0600
Delivery-date: Tue, 23 Jan 2007 08:24:18 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-ppc-devel-request@lists.xensource.com?subject=help>
List-id: Xen PPC development <xen-ppc-devel.lists.xensource.com>
List-post: <mailto:xen-ppc-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: IBM
Reply-to: jyoung5@xxxxxxxxxx
Sender: xen-ppc-devel-bounces@xxxxxxxxxxxxxxxxxxx
So I started to move HYPERVISOR_grant_table_op from
arch/powerpc/platforms/xen/gttab.c to hcall.c. Well this looks like it
may not be the best idea.

The reason is that it calls a static function,
gnttab_pre_unmap_grant_ref, in gttab.c that would need to be added to
include/xen/gnttab.h, and this would be the only needed for power. Where
folks can be a bit annoyed by. Don't know if it is the best idea to move
this now? What do think guys think.

Having HYPERVISOR_grant_table_op in hcall.c would have all the
hypercalls in one place, but would require a nice ifdef in a header that
some have been know to take issue with.


_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel

<Prev in Thread] Current Thread [Next in Thread>