Re: [XenPPC] [PATCH] [RFC] Xencomm patch to fix modules

[Hollis Blanchard <hollisb@xxxxxxxxxx>]

On Wed, 2007-01-17 at 21:20 -0600, Jerone Young wrote:
> I haven't had a chance to fully test this patch. As I have been having
> problems with my blade today. But here is the code for review. I'll get
> back to the list once it is fully tested.

This looks pretty good; just a couple issues left... :)

Rename HYPERVISOR_xen_version_userspace() to HYPERVISOR_xen_version(),
delete the old HYPERVISOR_xen_version(), and replace the call to
xencomm_create() with xencomm_map().

In fact, now that we have xencomm_map() and xencomm_map_early(),
xencomm_create() and xencomm_create_mini() should become static (and
don't export them in xencomm.h).

Don't forget to update the copyright statement on all these files.

diff -r e5962db17966 drivers/xen/core/xencomm.c
--- a/drivers/xen/core/xencomm.c        Wed Jan 17 10:25:30 2007 -0600
+++ b/drivers/xen/core/xencomm.c        Wed Jan 17 01:42:11 2007 -0600
@@ -123,9 +123,87 @@ void *xencomm_create_inline(void *ptr)
 {
        unsigned long paddr;

-       BUG_ON(!is_kernel_addr((unsigned long)ptr));
-
        paddr = (unsigned long)xencomm_pa(ptr);
        BUG_ON(paddr & XENCOMM_INLINE_FLAG);
        return (void *)(paddr | XENCOMM_INLINE_FLAG);
 }
We should change this to BUG_ON(!is_phys_contig((unsigned long)ptr)) to
prevent accidents.

As soon as these issues are solved and you've tested the patch with VIO
modules, I'll check it in.

-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel