WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ppc-devel

RE: [XenPPC] [PATCH] fix debug print in boot_of_alloc_init

To: "Jimi Xenidis" <jimix@xxxxxxxxxxxxxx>
Subject: RE: [XenPPC] [PATCH] fix debug print in boot_of_alloc_init
From: "Yoder Stuart-B08248" <stuart.yoder@xxxxxxxxxxxxx>
Date: Mon, 8 Jan 2007 16:37:51 -0700
Cc: xen-ppc-devel <xen-ppc-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 08 Jan 2007 15:37:25 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <BE71BE76-5A31-4AAE-9F05-FDBB9FDABED4@xxxxxxxxxxxxxx>
List-help: <mailto:xen-ppc-devel-request@lists.xensource.com?subject=help>
List-id: Xen PPC development <xen-ppc-devel.lists.xensource.com>
List-post: <mailto:xen-ppc-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-ppc-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Accze2mPAyNo7O01SPKv+v7xeJJzGwAAjChA
Thread-topic: [XenPPC] [PATCH] fix debug print in boot_of_alloc_init
 

> -----Original Message-----
> From: Jimi Xenidis [mailto:jimix@xxxxxxxxxxxxxx] 
>
> start is in bytes here
> >
> >              DBG("%s: marking 0x%x - 0x%lx\n", __func__,
> > -                pg << PAGE_SHIFT, start);
> > +                pg << PAGE_SHIFT, start << PAGE_SHIFT);
> >
> becomes "in pages" here
> >              start >>= PAGE_SHIFT;
> >              while (pg < MEM_AVAILABLE_PAGES && pg < start) {
> >

I see... Thanks.  There was a similar bug (for real) in code
removed by an earlier patch that led me to jump to the
conclusion the same shift was needed there.

Stuart

_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel

<Prev in Thread] Current Thread [Next in Thread>