WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ppc-devel

Re: [XenPPC] Continue instead of fail on device_type fetch error

To: Amos Waterland <apw@xxxxxxxxxx>
Subject: Re: [XenPPC] Continue instead of fail on device_type fetch error
From: Hollis Blanchard <hollisb@xxxxxxxxxx>
Date: Tue, 21 Nov 2006 15:25:50 -0600
Cc: xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 21 Nov 2006 13:29:02 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20061121202713.GA12496@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-ppc-devel-request@lists.xensource.com?subject=help>
List-id: Xen PPC development <xen-ppc-devel.lists.xensource.com>
List-post: <mailto:xen-ppc-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: IBM Linux Technology Center
References: <20061121185513.GA8374@xxxxxxxxxxxxxxxxxxxxx> <20061121202713.GA12496@xxxxxxxxxxxxxxxxxxxxx>
Reply-to: Hollis Blanchard <hollisb@xxxxxxxxxx>
Sender: xen-ppc-devel-bounces@xxxxxxxxxxxxxxxxxxx
Pushed, thanks.

-- 
Hollis Blanchard
IBM Linux Technology Center

On Tue, 2006-11-21 at 15:27 -0500, Amos Waterland wrote:
> The latest release of SLOF is missing mandatory "device_type" nodes for
> both ISA and system-controller (which are both busses).  Until this is
> fixed, Xen fails to boot on that release of SLOF.  So work around it by
> just printing a warning and continueing.  Thanks to Segher for pointing
> out a problem with the first version of this patch.
> 
> CC: Segher Boessenkool <segher@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Amos Waterland <apw@xxxxxxxxxx>
> 
> ---
> 
>  boot_of.c |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff -r b30cb72ed5e2 xen/arch/powerpc/boot_of.c
> --- a/xen/arch/powerpc/boot_of.c      Fri Nov 03 16:53:17 2006 -0500
> +++ b/xen/arch/powerpc/boot_of.c      Tue Nov 21 15:12:33 2006 -0500
> @@ -818,8 +818,10 @@ static int __init boot_of_serial(void *o
>              of_panic("package-to-path failed\n");
> 
>          rc = of_getprop(p, "device_type", type, sizeof (type));
> -        if (rc == OF_FAILURE)
> -            of_panic("fetching device type failed\n");
> +        if (rc == OF_FAILURE) {
> +            of_printf("%s: fetching type of `%s' failed\n", __func__, buf);
> +            continue;
> +        }
> 
>          if (strcmp(type, "serial") != 0)
>              continue;
> 
> _______________________________________________
> Xen-ppc-devel mailing list
> Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-ppc-devel


_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel

<Prev in Thread] Current Thread [Next in Thread>