[Xen-devel] Re: [XenPPC] [RFC][PATCH] Isolating ACM's architecture-dependent parts

[Stefan Berger <stefanb@xxxxxxxxxx>]

hollisb@xxxxxxxxxxxxxxxxxxxxxxx wrote on 09/13/2006
10:51:29 AM:

> > +
> > +static inline
> > +int acm_x86_init(multiboot_info_t *mbi,
> > +                 unsigned
int *initrdidx,
> > +                 unsigned
long initial_images_start)
> > +{
> > +    return 0;
> > +}
> > +
> > +#endif
> > +
> > +#endif
> 
> These are way too big to be static inlines. Make them regular functions
> please.
> 
> Other than that, this patch seems great.

Don't want to have that checked in so far, though.

What about the multiboot code. Do you think PPC will
be able to also use this part? Not that I would move it, it's more out
of curiosity.

   Stefan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel