Re: [Xen-devel] should vcpu_pause()/vcpu_sleep_nosync() give up?

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 6/9/06 2:18 pm, "Jimi Xenidis" <jimix@xxxxxxxxxxxxxx> wrote:

> First off, I realize I have an SMP bug where my second processor is
> hung somewhere, I'm not sure where, but for the sake of this argument
> lets assume it has suffered an unrecoverable fault.
> 
> My primary CPU is fine and is hung in vcpu_sleep_nosync() because the
> secondary will not clear its _VCPUF_running bit.

ITYM vcpu_sleep_sync(). Hint is in the name. ;-) The nosync variant does not
spin on the _running flag.

> While I have this error I would like to give up and try and recover
> from it.
> How long is long enuff?
> thoughts?

Holy crap!

Are you assuming that the offline CPU was not running anything other than
the idle loop or guest code, and that you'll simply destroy the guest if one
was running (since you can't really continue it)? Given that this is a
software bug, these assumptions are likely not true and the CPU has gone
down taking some locks with it. However, being optimistic, I suppose a few
100ms would be plenty to know that something is probably up.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel