WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ppc-devel

Re: [XenPPC] [xenppc-unstable] [POWERPC] memory cleanup (phase 2), destr

To: Hollis Blanchard <hollisb@xxxxxxxxxx>
Subject: Re: [XenPPC] [xenppc-unstable] [POWERPC] memory cleanup (phase 2), destroy (et. al) now work
From: Jimi Xenidis <jimix@xxxxxxxxxxxxxx>
Date: Mon, 14 Aug 2006 17:48:46 -0400
Cc: xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 14 Aug 2006 14:51:10 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1155589057.30510.130.camel@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-ppc-devel-request@lists.xensource.com?subject=help>
List-id: Xen PPC development <xen-ppc-devel.lists.xensource.com>
List-post: <mailto:xen-ppc-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=unsubscribe>
References: <E1GCd1N-0006fH-1h@xxxxxxxxxxxxxxxxxxxxx> <1155589057.30510.130.camel@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-ppc-devel-bounces@xxxxxxxxxxxxxxxxxxx

On Aug 14, 2006, at 4:57 PM, Hollis Blanchard wrote:

On Mon, 2006-08-14 at 14:02 +0000, Xen patchbot-xenppc-unstable wrote:
@@ -120,7 +121,6 @@ int arch_domain_create(struct domain *d)

 void arch_domain_destroy(struct domain *d)
 {
-    free_domheap_pages(d->arch.rma_page, d->arch.rma_order);
     htab_free(d);
 }

@@ -263,7 +263,7 @@ void sync_vcpu_execstate(struct vcpu *v)

 void domain_relinquish_resources(struct domain *d)
 {
-    /* nothing to do? */
+    free_domheap_pages(d->arch.rma_page, d->arch.rma_order);
 }

 void arch_dump_domain_info(struct domain *d)

Why do we free the HTAB in arch_domain_destroy(),
Xen heap
but free the RMA in
domain_relinquish_resources()?
Domheap

everytime you release !xenheap memory, it checks t->tot_pages and if its zero releases a d->recnt. only when the refcnt = 1 (made zero by destroy) will destroy get called.

-JX


_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel