[XenPPC] [PATCH] start-cpu has no return code

[Amos Waterland <apw@xxxxxxxxxx>]

According to this document:

 PowerPC Processor binding to: IEEE 1275-1994
 Standard for Boot (Initialization, Configuration) Firmware
 Revision: 2.1 (Approved Version)
 Date: November 6, 1996

The start-cpu client interface has the following signature:

 start-cpu
  IN: nodeid, pc, arg
  OUT: none

This patch reflects that, and makes us stop seeing a bogus OF_FAILURE if 
we do actually check the return code of of_start_cpu.  Tested on JS20
and JS21 blades.

Signed-off-by: Amos Waterland <apw@xxxxxxxxxx>

---

 boot_of.c |   11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff -r 058f2e27476d xen/arch/powerpc/boot_of.c
--- a/xen/arch/powerpc/boot_of.c        Mon Aug 07 17:49:16 2006 -0500
+++ b/xen/arch/powerpc/boot_of.c        Fri Aug 11 13:10:12 2006 -0400
@@ -304,12 +304,11 @@ static int __init of_instance_to_path(in
 
 static int __init of_start_cpu(int cpu, u32 pc, u32 reg)
 {
-    int rets[1] = { OF_FAILURE };
-
-    if ( of_call("start-cpu", 3, 0, rets, cpu, pc, reg) == OF_FAILURE )
-        return OF_FAILURE;
-
-    return rets[0];
+    int ret;
+
+    ret = of_call("start-cpu", 3, 0, NULL, cpu, pc, reg);
+
+    return ret;
 }
 
 static void __init of_test(const char *of_method_name)

_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel